Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #544: Correctly pass StopIteration trough wrappers #545

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix #544: Correctly pass StopIteration trough wrappers #545

merged 1 commit into from
Nov 12, 2024

Conversation

RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Oct 31, 2024 •
edited
Loading

Raising a StopIteration in a generator triggers a RuntimeError.
If the RuntimeError of a generator has the passed in StopIteration as cause
resume with that StopIteration as normal exception instead of failing with the RuntimeError.

closes #544

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny/fix-544-wrapper-stop-iteration-passtrough branch from 6dd41bd to 4cf313d Compare October 31, 2024 13:20
@RonnyPfannschmidt RonnyPfannschmidt linked an issue Oct 31, 2024 that may be closed by this pull request
StopIteration passtrough not handled correctly #544
Closed
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Oct 31, 2024
Open
nicoddemus
nicoddemus approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

changelog/544.bugfix.rst Outdated Show resolved Hide resolved
testing/test_multicall.py Outdated Show resolved Hide resolved
src/pluggy/_callers.py Show resolved Hide resolved
@RonnyPfannschmidt RonnyPfannschmidt marked this pull request as draft October 31, 2024 14:17
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny/fix-544-wrapper-stop-iteration-passtrough branch from ed5b22b to 44455ea Compare November 3, 2024 04:58
@RonnyPfannschmidt RonnyPfannschmidt marked this pull request as ready for review November 3, 2024 04:58
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny/fix-544-wrapper-stop-iteration-passtrough branch from 44455ea to eb49a73 Compare November 3, 2024 05:00
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Nov 3, 2024
Open
@RonnyPfannschmidt
fix pytest-dev#544: Correctly pass StopIteration trough wrappers
9cf2eaa 
Raising a StopIteration in a generator triggers a RuntimeError.
If the RuntimeError of a generator has the passed in StopIteration as cause
resume with that StopIteration as normal exception instead of failing with the RuntimeError.
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny/fix-544-wrapper-stop-iteration-passtrough branch from eb49a73 to 9cf2eaa Compare November 3, 2024 14:40
@RonnyPfannschmidt RonnyPfannschmidt merged commit 9d19d4b into pytest-dev:main Nov 12, 2024
15 of 18 checks passed
@RonnyPfannschmidt RonnyPfannschmidt deleted the ronny/fix-544-wrapper-stop-iteration-passtrough branch November 12, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech Awaiting requested review from bluetech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StopIteration passtrough not handled correctly
2 participants
@RonnyPfannschmidt @nicoddemus